Re: [linux][PATCH v8 2/2] dts: arm: at91: Add SAMA5D3-EDS Board

[Krzysztof Kozlowski]

On 09/09/2022 00:21, Jerry Ray wrote:
> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for
> evaluating many Microchip ethernet switch and PHY products.  Various
> daughter cards can connect via an RGMII connector or an RMII connector.
> 
> The EDS board is not intended for stand-alone use and has no ethernet
> capabilities when no daughter board is connected.  As such, this device
> tree is intended to be used with a DT overlay defining the add-on board.
> To better ensure consistency, some items are defined here as a form of
> documentation so that all add-on overlays will use the same terms.
> 
> Link: https://www.microchip.com/en-us/development-tool/SAMA5D3-ETHERNET-DEVELOPMENT-SYSTEM
> 
> Signed-off-by: Jerry Ray <jerry.ray@xxxxxxxxxxxxx>
> ---
> v7->v8:
>  - correcting patch subject line.
> v6->v7:
>  - Renamed regulators, making things more consistent.
>  - Made slow_xtal and main_xtal entries direct overrides.
> v5->v6:
>  - Replaced underscores in names where I can, improving naming.
> v4->v5:
>  - patch now applies to v6.0-rc2
> v3->v4:
>  - Fixed regulators as necessary to get the board to boot from SD Card.
> v2->v3:
>  - Alphabetized pinctrl entries.
>  - cleaned up a warning in the regulators section.
>  - License tweaked to 'OR MIT'
>  - Included Makefile change
> v1->v2:
>  - Modified the compatible field in the device tree to reflect Microchip
>    Ethernet Development System Board.
> ---
>  arch/arm/boot/dts/Makefile             |   1 +
>  arch/arm/boot/dts/at91-sama5d3_eds.dts | 307 +++++++++++++++++++++++++
>  2 files changed, 308 insertions(+)
>  create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 05d8aef6e5d2..e92e639a2dc3 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
>  	at91-sama5d2_icp.dtb \
>  	at91-sama5d2_ptc_ek.dtb \
>  	at91-sama5d2_xplained.dtb \
> +	at91-sama5d3_eds.dtb \
>  	at91-sama5d3_ksz9477_evb.dtb \
>  	at91-sama5d3_xplained.dtb \
>  	at91-dvk_som60.dtb \
> diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts b/arch/arm/boot/dts/at91-sama5d3_eds.dts
> new file mode 100644
> index 000000000000..c7fbf7aa7826
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts
> @@ -0,0 +1,307 @@
> +// SPDX-License-Identifier: GPL-2.0+ OR MIT
> +/*
> + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet
> + *    Development System board.
> + *
> + * Copyright (C) 2022 Microchip Technology Inc. and its subsidiaries
> + *
> + * Author: Jerry Ray <jerry.ray@xxxxxxxxxxxxx>
> + */
> +/dts-v1/;
> +#include "sama5d36.dtsi"
> +
> +/ {
> +	model = "SAMA5D3 Ethernet Development System";
> +	compatible = "microchip,sama5d3-eds", "atmel,sama5d36",
> +		     "atmel,sama5d3", "atmel,sama5";
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
> +	gpio {

gpio is for GPIO controller. These are keys/buttons and usually it is
'gpio-keys' as node name.


Best regards,
Krzysztof