Re: [PATCH v1 1/1] pinctrl: cy8c95x0: Use 'default' in all switch-cases (part 2)

[Andy Shevchenko]

On Fri, Sep 09, 2022 at 10:02:51AM +0200, Linus Walleij wrote:
> On Thu, Sep 8, 2022 at 4:21 PM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> 
> > Move the default values to the 'default' case in the switches.

> Patch applied!

Thanks!

...

> >         case CY8C95X0_DRV_PP_SLOW:
> >         case CY8C95X0_DRV_HIZ:
> >                 return true;
> > +       default:
> > +               return false;
> >         }
> > -
> > -       return false;
> 
> Clearly this is better style, I wonder if we could teach checkpatch to
> look for this? Or cocinelle?

The latter I believe. But I'm too busy and too lazy to go that road.

-- 
With Best Regards,
Andy Shevchenko