Re: [PATCH 2/2] perf tools: remove perf_pmu_lex declaration

From: Arnaldo Carvalho de Melo
Date: Fri Sep 09 2022 - 09:45:38 EST

Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
> On 09/09/2022 05:45, Gaosheng Cui wrote:
> > perf_pmu_lex has been removed since
> > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > so remove it.
> Not 100% sure if that is the right commit to reference because it didn't
> touch pmu.y.

Yeah, indeed, unsure if at that time the declaration was needed.

> perf_pmu_lex is still used and there are plenty of references to it, but
> maybe the extern declaration isn't needed anymore because it still
> builds for me with this change.

Ditto here, I'll remove the reference and rewrite the cset log a bit.

- Arnaldo