Re: [PATCH] staging: rtl8192e: Fix return type for implementation of ndo_start_xmit

[Philipp Hortmann]

On 9/9/22 20:01, Greg Kroah-Hartman wrote:
> On Fri, Sep 09, 2022 at 07:20:09PM +0200, Philipp Hortmann wrote:
> > On 9/9/22 10:00, Greg Kroah-Hartman wrote:
> > > On Fri, Sep 09, 2022 at 09:56:59AM +0200, Greg Kroah-Hartman wrote:
> > > > On Thu, Sep 08, 2022 at 10:32:43PM +0200, Philipp Hortmann wrote:
> > > > > CFI (Control Flow Integrity) is a safety feature allowing the system to
> > > > > detect and react should a potential control flow hijacking occurs. In
> > > > > particular, the Forward-Edge CFI protects indirect function calls by
> > > > > ensuring the prototype of function that is actually called matches the
> > > > > definition of the function hook.
> > > > >
> > > > > Since Linux now supports CFI, it will be a good idea to fix mismatched
> > > > > return type for implementation of hooks. Otherwise this would get
> > > > > cought out by CFI and cause a panic.
> > > > >
> > > > > Use enums from netdev_tx_t as return value instead, then change return
> > > > > type to netdev_tx_t.
> > > > >
> > > > > Suggested-by: Dan Carpenter <error27@xxxxxxxxx>
> > > > > Signed-off-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>
> > > > > ---
> > > > > Tested with rtl8192e
> > > > > Transferred this patch over wlan connection of rtl8192e
> > > > > ---
> > > > >    drivers/staging/rtl8192e/rtllib.h    |  2 +-
> > > > >    drivers/staging/rtl8192e/rtllib_tx.c | 10 +++++-----
> > > > >    2 files changed, 6 insertions(+), 6 deletions(-)
> > > >
> > > > Someone sent the same patch before you did:
> > > > 	https://lore.kernel.org/r/20220905130053.10731-1-guozihua@xxxxxxxxxx
> > >
> > > This patch does not apply to my tree either :(
> > >
> > > Please rebase and resubmit.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> >
> > Sorry Greg,
> >
> > I cannot find my error.
> > I just downloaded the patch and applied it to the staging-next branch and
> > that worked fine.
>
> Try the staging-testing branch please.
>
> thanks,
>
> greg k-h

Hi Greg,

After switching the branch and a git pull the patch form GUO Zihua is 
already in.

Author: GUO Zihua <guozihua@xxxxxxxxxx>
Date:   Mon Sep 5 21:00:53 2022 +0800

    staging: rtl8192e: Fix return type for implementation of ndo_start_xmit

So nothing to do.

Bye Philipp