Re: [RFC PATCH v3 4/4] ufs: host: qcom: Add MCQ support

[Asutosh Das (asd)]

Hello Bart,
Thanks for taking a look.

On 9/8/2022 3:30 PM, Bart Van Assche wrote:
> On 9/2/22 15:41, Asutosh Das wrote:
> > +static int ufs_qcom_get_hba_mac(struct ufs_hba *hba)
> > +{
> > +    return MAX_SUPP_MAC;
> > +}
>
> The above implementation is not sufficient to convince me that the 
> get_hba_mac vop is useful. Please remove this vop and use MAX_SUPP_MAC 
> directly where ufshcd_mcq_vops_get_hba_mac() is called.
The default value of MAC is 32 but it can have a max value of 256.
Here it has a value of 64.
So I think this vops would be helpful for other HC vendors as well who 
may have a different value than the default.

> Thanks,
>
> Bart.

-asd