Re: [PATCHv3 13/14] regulator: rk808: add rk806 support

From: Matti Vaittinen
Date: Sat Sep 10 2022 - 13:04:00 EST


Hi deee Ho Sebastian,

On 9/9/22 20:55, Sebastian Reichel wrote:
Add rk806 support to the existing rk808 regulator
driver.

This has been implemented using shengfei Xu's rk806
specific driver from the vendor tree as reference.

Co-Developed-by: shengfei Xu <xsf@xxxxxxxxxxxxxx>
Signed-off-by: shengfei Xu <xsf@xxxxxxxxxxxxxx>
Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxx>
---
drivers/regulator/rk808-regulator.c | 384 ++++++++++++++++++++++++++++
1 file changed, 384 insertions(+)

diff --git a/drivers/regulator/rk808-regulator.c b/drivers/regulator/rk808-regulator.c
index fa9fc1aa1ae3..8ef276ef44e3 100644
--- a/drivers/regulator/rk808-regulator.c
+++ b/drivers/regulator/rk808-regulator.c
@@ -3,9 +3,11 @@

// snip

+static const struct regulator_ops rk806_ops_dcdc = {
+ .list_voltage = regulator_list_voltage_linear_range,
+ .map_voltage = regulator_map_voltage_linear_range,
+ .get_voltage_sel = regulator_get_voltage_sel_regmap,
+ .set_voltage_sel = regulator_set_voltage_sel_regmap,
+ .set_voltage_time_sel = regulator_set_voltage_time_sel,
+ .set_mode = rk806_set_mode_dcdc,
+ .get_mode = rk806_get_mode_dcdc,
+
+ .enable = regulator_enable_regmap,
+ .disable = regulator_disable_regmap,
+ .is_enabled = regulator_is_enabled_regmap,
+
+ .set_suspend_mode = rk806_set_mode_dcdc,
+ .set_ramp_delay = rk806_set_ramp_delay_dcdc,
+ //.set_ramp_delay = regulator_set_ramp_delay_regmap,

I guess leaving this was the eye-catcher for reviewers who have urge to nag about something ;)

Other than that - for what it matters
Reviewed-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>

Best Regards
-- Matti

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~