Re: [PATCHv3 12/14] regulator: expose regmap_find_closest_bigger

From: Matti Vaittinen
Date: Sat Sep 10 2022 - 13:17:28 EST


pe 9. syysk. 2022 klo 21.21 Sebastian Reichel
(sebastian.reichel@xxxxxxxxxxxxx) kirjoitti:
>
> Expose and document the table lookup logic used by
> regulator_set_ramp_delay_regmap, so that it can be
> reused for devices that cannot be configured via
> regulator_set_ramp_delay_regmap.
>

I am always in favor of adding helpers to be used for common tasks. I
am not demanding this (so please ignore my comment if you feel so) but
I guess finding the "closest bigger" from a table is not ramp-delay or
even regulator specific. I believe something like this might live
under lib - if exported.

Anyways, and whatever it is worth:
Acked-by: Matti Vaittinen <matti.vaittinen@mazziesaccount@xxxxxxxxx>
for exporting such a helper. (Or please disregard the ack if acks are
reserved only for maintainers - It's just a sign that I think this is
a good idea [even if it could live in lib])

Yours
-- Matti
--

Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~