Re: [PATCH v3 1/2] Add CABA tree to task_struct

[kernel test robot]

Hi Pavel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on shuah-kselftest/next]
[also build test WARNING on kees/for-next/execve tip/sched/core linus/master v6.0-rc4 next-20220909]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Pavel-Tikhomirov/Introduce-CABA-helper-process-tree/20220908-220639
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
config: ia64-randconfig-s041-20220911 (https://download.01.org/0day-ci/archive/20220912/202209120356.YizhqUik-lkp@xxxxxxxxx/config)
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-39-gce1a6720-dirty
        # https://github.com/intel-lab-lkp/linux/commit/17a897a33137d4f49f99c8be8d619f6f711fccdb
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Pavel-Tikhomirov/Introduce-CABA-helper-process-tree/20220908-220639
        git checkout 17a897a33137d4f49f99c8be8d619f6f711fccdb
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=ia64 SHELL=/bin/bash arch/ia64/kernel/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

sparse warnings: (new ones prefixed by >>)
   arch/ia64/kernel/mca.c:504:1: sparse: sparse: symbol 'search_mca_table' was not declared. Should it be static?
   arch/ia64/kernel/mca.c:607:1: sparse: sparse: symbol 'ia64_mca_register_cpev' was not declared. Should it be static?
   arch/ia64/kernel/mca.c:831:5: sparse: sparse: symbol 'ia64_mca_ucmc_extension' was not declared. Should it be static?
   arch/ia64/kernel/mca.c:1793:36: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct task_struct [noderef] __rcu *real_parent @@     got struct task_struct *group_leader @@
   arch/ia64/kernel/mca.c:1793:36: sparse:     expected struct task_struct [noderef] __rcu *real_parent
   arch/ia64/kernel/mca.c:1793:36: sparse:     got struct task_struct *group_leader
>> arch/ia64/kernel/mca.c:1796:17: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected struct task_struct [noderef] __rcu *caba @@     got struct task_struct *p @@
   arch/ia64/kernel/mca.c:1796:17: sparse:     expected struct task_struct [noderef] __rcu *caba
   arch/ia64/kernel/mca.c:1796:17: sparse:     got struct task_struct *p
   arch/ia64/kernel/mca.c:2106:43: sparse: sparse: Using plain integer as NULL pointer

vim +1796 arch/ia64/kernel/mca.c

  1770	
  1771	/* Minimal format of the MCA/INIT stacks.  The pseudo processes that run on
  1772	 * these stacks can never sleep, they cannot return from the kernel to user
  1773	 * space, they do not appear in a normal ps listing.  So there is no need to
  1774	 * format most of the fields.
  1775	 */
  1776	
  1777	static void
  1778	format_mca_init_stack(void *mca_data, unsigned long offset,
  1779			const char *type, int cpu)
  1780	{
  1781		struct task_struct *p = (struct task_struct *)((char *)mca_data + offset);
  1782		struct thread_info *ti;
  1783		memset(p, 0, KERNEL_STACK_SIZE);
  1784		ti = task_thread_info(p);
  1785		ti->flags = _TIF_MCA_INIT;
  1786		ti->preempt_count = 1;
  1787		ti->task = p;
  1788		ti->cpu = cpu;
  1789		p->stack = ti;
  1790		p->__state = TASK_UNINTERRUPTIBLE;
  1791		cpumask_set_cpu(cpu, &p->cpus_mask);
  1792		INIT_LIST_HEAD(&p->tasks);
  1793		p->parent = p->real_parent = p->group_leader = p;
  1794		INIT_LIST_HEAD(&p->children);
  1795		INIT_LIST_HEAD(&p->sibling);
> 1796		p->caba = p;
  1797		INIT_LIST_HEAD(&p->cabds);
  1798		INIT_LIST_HEAD(&p->cabd);
  1799		strncpy(p->comm, type, sizeof(p->comm)-1);
  1800	}
  1801	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp