RE: [RESEND PATCH v9 1/3] dt-bindings: mfd: Convert atmel-flexcom to json-schema

From: Kavyasree.Kotagiri
Date: Mon Sep 12 2022 - 04:16:31 EST


> > > Convert the Atmel flexcom device tree bindings to json schema.
> > >
> > > Signed-off-by: Kavyasree Kotagiri <kavyasree.kotagiri@xxxxxxxxxxxxx>
> > > ---
> > > v8 -> v9:
> > > - Changed reference provided for spi bindings to atmel,at91rm9200-
> > spi.yaml
> > >
> > > v7 -> v8:
> > > - Added back patternProperties for child nodes.
> > >
> > > v6 -> v7:
> > > - Change filename to atmel,sama5d2-flexcom.yaml
> > > - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
> > >
> > > v5 -> v6:
> > > - Removed spi node from example as suggested by Rob and
> > > also pattern properties(spi dt-bindings conversion to yaml patch is
> under
> > review).
> > > Once that is accepted, I will add back spi example through new patch.
> > >
> > > v4 -> v5:
> > > - Fixed indentations.
> > >
> > > v3 -> v4:
> > > - Corrected format of enum used for compatible string.
> > >
> > > v2 -> v3:
> > > - used enum for compatible string.
> > > - changed irq flag to IRQ_TYPE_LEVEL_HIGH in example.
> > > - fixed dtschema errors.
> > >
> > > v1 -> v2:
> > > - Fix title.
> > >
> > > .../bindings/mfd/atmel,sama5d2-flexcom.yaml | 91
> > +++++++++++++++++++
> > > .../devicetree/bindings/mfd/atmel-flexcom.txt | 63 -------------
> > > 2 files changed, 91 insertions(+), 63 deletions(-)
> > > create mode 100644
> > Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> > flexcom.txt
> > >
> >
> > Running 'make dtbs_check' with the schema in this patch gives the
> > following warnings. Consider if they are expected or the schema is
> > incorrect. These may not be new warnings.
> >
> > Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> > This will change in the future.
> >
> > Full log is available here: https://patchwork.ozlabs.org/patch/
> >
> >
> > flexcom@e0040000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> > arch/arm/boot/dts/lan966x-pcb8291.dtb
> > arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@e0044000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> > arch/arm/boot/dts/lan966x-pcb8291.dtb
> > arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@e0060000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> > arch/arm/boot/dts/lan966x-pcb8291.dtb
> > arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@e0064000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> > arch/arm/boot/dts/lan966x-pcb8291.dtb
> > arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@e0070000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-6g-2gs.dtb
> > arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt-8g.dtb
> > arch/arm/boot/dts/lan966x-pcb8291.dtb
> > arch/arm/boot/dts/lan966x-pcb8309.dtb
> >
> > flexcom@e2824000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> > arch/arm/boot/dts/at91-sama7g5ek.dtb
> >
> > flexcom@f8034000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> > arch/arm/boot/dts/at91-kizbox3-hs.dtb
> > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_icp.dtb
> > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> >
> > flexcom@f8038000: spi@400: Unevaluated properties are not allowed
> > ('dma-names', 'dmas' were unexpected)
> > arch/arm/boot/dts/at91-kizbox3-hs.dtb
> > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_icp.dtb
> > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> >
> > flexcom@fc010000: spi@400: Unevaluated properties are not allowed
> ('dma-
> > names', 'dmas' were unexpected)
> > arch/arm/boot/dts/at91-kizbox3-hs.dtb
> > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_icp.dtb
> > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> >
> > flexcom@fc014000: spi@400: Unevaluated properties are not allowed
> ('dma-
> > names', 'dmas' were unexpected)
> > arch/arm/boot/dts/at91-kizbox3-hs.dtb
> > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_icp.dtb
> > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_xplained.dtb
> >
> > flexcom@fc018000: spi@400: Unevaluated properties are not allowed
> ('dma-
> > names', 'dmas' were unexpected)
> > arch/arm/boot/dts/at91-kizbox3-hs.dtb
> > arch/arm/boot/dts/at91-sama5d27_som1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d27_wlsom1_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_icp.dtb
> > arch/arm/boot/dts/at91-sama5d2_ptc_ek.dtb
> > arch/arm/boot/dts/at91-sama5d2_xplained.dtb
>
> dma properties for spi node is already being covered by Sergiu in below
> patch:
> https://lore.kernel.org/lkml/b4625526-8f9b-ada8-f854-
> 751a48545576@xxxxxxxxxx/
>
Hi Rob, Please let me know your comments.

Thanks,
Kavya

>
> Thanks,
> Kavya