Re: [PATCH devicetree] arm64: dts: ls1028a-rdb: add more ethernet aliases
From: Shawn Guo
Date: Mon Sep 12 2022 - 05:26:25 EST
On Tue, Sep 06, 2022 at 12:24:58AM +0300, Vladimir Oltean wrote:
> Commit "arm64: dts: ls1028a: enable swp5 and eno3 for all boards" which
> Shawn declared as applied, but for which I can't find a sha1sum, has
> enabled a new Ethernet port on the LS1028A-RDB (&enetc_port3), but
> U-Boot, which passes a MAC address to Linux' device tree through the
> /aliases node, fails to do this for this newly enabled port.
>
> Fix that by adding more ethernet aliases in the only
> backwards-compatible way possible: at the end of the current list.
>
> And since it is possible to very easily convert either swp4 or swp5 to
> DSA user ports now (which have a MAC address of their own), using these
> U-Boot commands:
>
> => fdt addr $fdt_addr_r
> => fdt rm /soc/pcie@1f0000000/ethernet-switch@0,5/ports/port@4 ethernet
>
> it would be good if those DSA user ports (swp4, swp5) gained a valid MAC
> address from U-Boot as well. In order for that to work properly,
> provision two more ethernet aliases for &mscc_felix_port{4,5} as well.
>
> The resulting ordering is slightly unusual, but to me looks more natural
> than eno0, eno2, swp0, swp1, swp2, swp3, eno3, swp4, swp5.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Applied, thanks!