RE: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")

From: Kumaravel.Thiagarajan
Date: Mon Sep 12 2022 - 07:48:50 EST


> -----Original Message-----
> From: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>
> Sent: Friday, September 9, 2022 11:22 PM
> To: Kumaravel Thiagarajan - I21417 <Kumaravel.Thiagarajan@xxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Arnd Bergmann
> <arnd@xxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx; linux-kernel <linux-
> kernel@xxxxxxxxxxxxxxx>; linux-next <linux-next@xxxxxxxxxxxxxxx>
> Subject: Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc:
> microchip: pci1xxxx: Add power management functions - suspend & resume
> handlers.")
>
> On Fri, Sep 9, 2022 at 4:12 PM <Kumaravel.Thiagarajan@xxxxxxxxxxxxx>
> wrote:
> >
> > > -----Original Message-----
> > > From: Sudip Mukherjee (Codethink) <sudipm.mukherjee@xxxxxxxxx>
> > > Sent: Tuesday, September 6, 2022 7:53 PM
> > > To: Kumaravel Thiagarajan - I21417
> > > <Kumaravel.Thiagarajan@xxxxxxxxxxxxx>; Greg Kroah-Hartman
> > > <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Cc: Arnd Bergmann <arnd@xxxxxxxx>; linux-gpio@xxxxxxxxxxxxxxx;
> > > linux- kernel@xxxxxxxxxxxxxxx; linux-next@xxxxxxxxxxxxxxx
> > > Subject: build failure of next-20220906 due to 4ec7ac90ff39 ("misc:
> microchip:
> > > pci1xxxx: Add power management functions - suspend & resume
> > > handlers.")
> > >
> > > Hi All,
> > >
> > > The builds of riscv, s390, csky, alpha and loongarch allmodconfig
> > > have failed to build next-20220906 with the error:
> > >
> > >
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error:
> > > 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-
> function]
> > > 311 | static int pci1xxxx_gpio_resume(struct device *dev)
> > > | ^~~~~~~~~~~~~~~~~~~~
> > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error:
> > > 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-
> function]
> > > 295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> > > | ^~~~~~~~~~~~~~~~~~~~~
> > >
> > >
> > > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add
> > > power management functions - suspend & resume handlers.").
> > >
> > > I will be happy to test any patch or provide any extra log if needed.
> > Sudip, can you please share the .config file that you used for riscv and if
> possible other .config files too?
>
> Sure, here is the one for loongarch and riscv. Please let me know if you need
> the others and I can generate them for you. These are just the normal
> allmodconfig nothing special.
> Not sure what you are trying to see here, but imho, you will see the problem
> if you check the definition of SET_SYSTEM_SLEEP_PM_OPS in
> include/linux/pm.h.
Sudip, Thank you for sharing additional information and it helped so much.

Regards,
Kumaravel