Re: [PATCH v2 2/8] ARM: dts: uniphier: Rename usb-phy node to usb-glue

[Kunihiko Hayashi]

Hi Arnd,

Thank you for checking.

On 2022/09/12 17:32, Arnd Bergmann wrote:
> On Mon, Sep 12, 2022, at 9:15 AM, Kunihiko Hayashi wrote:
> > Actual phy nodes are each child node. The parent node should be usb-glue
> > node. This applies to the devicetre for Pro4 SoC.
> >
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@xxxxxxxxxxxxx>
> > ---
> >   arch/arm/boot/dts/uniphier-pro4.dtsi | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/uniphier-pro4.dtsi
> > b/arch/arm/boot/dts/uniphier-pro4.dtsi
> > index a53b73ee93e9..cf62821c69ca 100644
> > --- a/arch/arm/boot/dts/uniphier-pro4.dtsi
> > +++ b/arch/arm/boot/dts/uniphier-pro4.dtsi
> > @@ -376,7 +376,7 @@ pinctrl: pinctrl {
> >   				compatible =
> "socionext,uniphier-pro4-pinctrl";
> >   			};
> >
> > -			usb-phy {
> > +			usb-glue {
> >   				compatible =
> "socionext,uniphier-pro4-usb2-phy";
> >   				#address-cells = <1>;
> >   				#size-cells = <0>;
>
> Not sure about this one. What hardware does this node
> actaully represent? I don't see any other soc dts files
> refer to node names as 'glue', so there is probably a
> better name for it. In the binding document, it's called
> "usb-controller", but I'm not sure that is the right name
> either.
Surely, "glue" is uncommon, and "usb-controller" is suitable
to represent the integration of usb-related functionality.
I'll review the node names.

Thank you,

---
Best Regards
Kunihiko Hayashi