Re: [PATCH v9 23/27] Kbuild: add Rust support

From: Masahiro Yamada
Date: Tue Sep 13 2022 - 02:38:32 EST


On Tue, Sep 13, 2022 at 1:18 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> Hi Masahiro,
>
> On Mon, Sep 12, 2022 at 5:08 PM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
> >
> > I have not figured out where this difference comes from.
>
> It is the `RUSTC_BOOTSTRAP` environment variable: it allows to use
> unstable featuers in the stable compiler.


Thanks, I learned a new thing.


>
> We currently set it in the global `Makefile`, but we could be more
> explicit and do it on each command if you think that would be better.


I checked "make compile_commands.json", but it collects build commands
only for C.


I did not see any bad scenario with the current approach.








>
> If you want that we keep using the global export, then we can add a
> comment explaining this to clarify.
>
> Cheers,
> Miguel
--
Best Regards
Masahiro Yamada