Re: [PATCH] proc/vmcore: fix potential memory leak in vmcore_init()

[Baoquan He]

On 09/13/22 at 07:35am, Matthew Wilcox wrote:
> On Tue, Sep 13, 2022 at 02:25:01PM +0800, Jianglei Nie wrote:
> >  	}
> > -	elfcorehdr_free(elfcorehdr_addr);
> >  	elfcorehdr_addr = ELFCORE_ADDR_ERR;
> >  
> >  	proc_vmcore = proc_create("vmcore", S_IRUSR, NULL, &vmcore_proc_ops);
> >  	if (proc_vmcore)
> >  		proc_vmcore->size = vmcore_size;
> > -	return 0;
> > +
> > +fail:
> > +	elfcorehdr_free(elfcorehdr_addr);
> > +	return rc;
> >  }
> 
> Did you test this?  It looks like you now call
> elfcorehdr_free(ELFCORE_ADDR_ERR) if 'rc' is 0.

Right, that will cause problem. It's my fault since I suggested
the current change.

Jianglei, please use your v1 change and post again. Sorry for the
incorrect suggestion.