Re: [PATCH] mm/damon/sysfs: use the wrapper directly to check if the kdamond is running

[SeongJae Park]

Hi Kaixu,

On Mon, 12 Sep 2022 23:11:53 +0800 xiakaixu1987@xxxxxxxxx wrote:

> From: Kaixu Xia <kaixuxia@xxxxxxxxxxx>
> 
> We can use the 'damon_sysfs_kdamond_running()' wrapper directly to
> check if the kdamond is running in 'damon_sysfs_turn_damon_on()'.
> 
> Signed-off-by: Kaixu Xia <kaixuxia@xxxxxxxxxxx>

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

> ---
>  mm/damon/sysfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
> index 7488e27c87c3..84861c4085a5 100644
> --- a/mm/damon/sysfs.c
> +++ b/mm/damon/sysfs.c
> @@ -2455,8 +2455,7 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond)
>  	struct damon_ctx *ctx;
>  	int err;
>  
> -	if (kdamond->damon_ctx &&
> -			damon_sysfs_ctx_running(kdamond->damon_ctx))
> +	if (damon_sysfs_kdamond_running(kdamond))
>  		return -EBUSY;
>  	if (damon_sysfs_cmd_request.kdamond == kdamond)
>  		return -EBUSY;
> -- 
> 2.27.0
>