Re: [PATCH 0/4] mm/damon: code simplifications and cleanups

From: SeongJae Park
Date: Tue Sep 13 2022 - 12:26:15 EST


On Tue, 13 Sep 2022 17:11:23 +0800 xiakaixu1987@xxxxxxxxx wrote:

> From: Kaixu Xia <kaixuxia@xxxxxxxxxxx>
>
> This patchset contains some code simplifications and cleanups
> for DAMON.

For the first three patches,

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>

But, I have a question for the last one. Please answer it.

Thanks,
SJ

>
> Kaixu Xia (4):
> mm/damon: simplify the parameter passing for 'prepare_access_checks'
> mm/damon/sysfs: simplify the variable 'pid' assignment operation
> mm/damon/core: simplify the kdamond stop mechanism by removing 'done'
> mm/damon/vaddr: indicate the target is invalid when 'nr_regions' is
> zero
>
> mm/damon/core.c | 24 +++++++++---------------
> mm/damon/paddr.c | 5 ++---
> mm/damon/sysfs.c | 11 ++++-------
> mm/damon/vaddr.c | 9 ++++++---
> 4 files changed, 21 insertions(+), 28 deletions(-)
>
> --
> 2.27.0