Re: [PATCH 04/12] staging: vt6655: Cleanup and rename function MACbSafeSoftwareReset
From: Philipp Hortmann
Date: Tue Sep 13 2022 - 14:46:27 EST
On 9/13/22 12:12, Dan Carpenter wrote:
On Sun, Sep 11, 2022 at 12:46:04PM +0200, Philipp Hortmann wrote:
Rename function MACbSafeSoftwareReset to vt6655_mac_save_soft_reset and
abyTmpRegData to tmp_reg_data to avoid CamelCase which is not accepted by
checkpatch.pl. Remove return value bRetVal as it is unused by the calling
functions.
Please don't mix this kind of stuff into a patch like this.
In the past Greg let me know that I used to many patches for a change in
the same lines of code and that it would be easier for him to review
when less patches do the same.
As you wrote I am changing to many things at once. Sorry for breaking
your automatism.
I will consider your hints for the next patches.
Thanks
Bye Philipp