Re: [PATCH 0/4] Make QMI message rules const
From: Alex Elder
Date: Tue Sep 13 2022 - 16:21:42 EST
On 9/13/22 1:51 PM, Jeff Johnson wrote:
On 9/13/2022 6:58 AM, Alex Elder wrote:
On 9/12/22 6:25 PM, Jeff Johnson wrote:
Change ff6d365898d ("soc: qcom: qmi: use const for struct
qmi_elem_info") allows QMI message encoding/decoding rules to be
const. So now update the definitions in the various client to take
advantage of this. Patches for ath10k and ath11k were perviously sent
separately.
I have had this on my "to-do list" for ages.
The commit you mention updates the code to be
explicit about not modifying this data, which
is great.
I scanned over the changes, and I assume that
all you did was make every object having the
qmi_elem_info structure type be defined as
constant.
Why aren't you changing the "ei_array" field in
the qmi_elem_info structure to be const? Or the
"ei" field of the qmi_msg_handler structure? And
the qmi_response_type_v01_ei array (and so on)?
I like what you're doing, but can you comment
on what your plans are beyond this series?
Do you intend to make the rest of these fields
const?
Hi Alex,
My primary focus is the ath* wireless drivers, and my primary goal was
to make the tables there const. So this series, along with the two
out-of-series patches for ath10k and ath11k complete that scope of work.
The lack of the other changes to the QMI data structures is simply due
to me not looking in depth at the QMI code beyond the registration
interface.
I'll be happy to revisit this as a separate cleanup.
Sounds good to me. Like I said I've wanted to do this
myself, and as long as you've gotten this far I'd like
to see it taken to completion. Compile-testing is most
likely sufficient to make sure you got it right.
I cherry-picked the one commit, and downloaded the series
and found no new build warnings. Checkpatch would prefer
you used "ff6d365898d4" rather than "ff6d365898d" for the
commit ID, but that's OK.
Anyway, for the whole series:
Reviewed-by: Alex Elder <elder@xxxxxxxxxx>
/jeff