On Mon, Sep 12, 2022 at 09:50:26PM +0200, Danilo Krummrich wrote:
Hi Liviu,
Hi Danilo,
Thanks for having a look!
This is not about this patch, it's about patch 3/7 "drm/arm/hdlcd: crtc: use
drmm_crtc_init_with_planes()".
Agree! However, this is the patch that removes the .destroy hook, so I've replied here.
And there it's the other way around. When using drmm_crtc_init_with_planes()
we shouldn't have a destroy hook in place, that's the whole purpose of
drmm_crtc_init_with_planes().
We should just drop patch 3/7 "drm/arm/hdlcd: crtc: use
drmm_crtc_init_with_planes()", it's wrong.
So we end up with mixed use of managed and unmanaged APIs?
Do you want me to send a v2 for that?
Yes please! It would help me to understand your thinking around the whole lifecycle of the driver.
BTW, I appreciate the care in patches 5-7 to make sure that the driver doesn't access freed resources,
however I'm not sure I like the fact that rmmod-ing the hdlcd driver while I have an fbcon running
hangs now the command and prevents a kernel reboot, while it works without your series. Can you explain
to me again what are you trying to fix?
Best regards,
Liviu
- Danilo
On 9/12/22 19:36, Liviu Dudau wrote:
Hi Danilo,
I have applied your patch series for HDLCD on top of drm-next (commit 213cb76ddc8b)
and on start up I get a warning:
[ 12.882554] hdlcd 7ff50000.hdlcd: drm_WARN_ON(funcs && funcs->destroy)
[ 12.882596] WARNING: CPU: 1 PID: 211 at drivers/gpu/drm/drm_crtc.c:393 __drmm_crtc_init_with_planes+0x70/0xf0 [drm]
It looks like the .destroy hook is still required or I'm missing some other required
series where the WARN has been removed?
Best regards,
Liviu