Re: [PATCH v3 06/15] arm64: dts: qcom: msm8953: add missing TCSR syscon compatible

[Bjorn Andersson]

On Fri, Sep 09, 2022 at 11:20:26AM +0200, Krzysztof Kozlowski wrote:
> TCSR syscon node should come with dedicated compatible.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/msm8953.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> index 8416a45ca4fd..ed05897d33f1 100644
> --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi
> @@ -722,7 +722,7 @@ tcsr: syscon@1937000 {
>  		};
>  
>  		tcsr_phy_clk_scheme_sel: syscon@193f044 {
> -			compatible = "syscon";
> +			compatible = "qcom,tcsr-msm8953", "syscon";
>  			reg = <0x193f044 0x4>;

I'm okay with the proposed change, but this node is not good.

This exposes a single register from TCSR to the HSUSB driver. We have a
couple of these cases (and have had more popping up in discussions) and
I think that nvmem would be a better abstraction than syscon.

Regards,
Bjorn

>  		};
>  
> -- 
> 2.34.1
>