Re: [PATCH v4 1/2] mm: hugetlb: simplify per-node sysfs creation and removal

[David Hildenbrand]

On 14.09.22 09:26, Muchun Song wrote:
> The following commit offload per-node sysfs creation and removal to a
> kworker and did not say why it is needed.  And it also said "I don't know
> that this is absolutely required".  It seems like the author was not sure
> as well.  Since it only complicates the code, this patch will revert the
> changes to simplify the code.
>
>    39da08cb074c ("hugetlb: offload per node attribute registrations")
>
> We could use memory hotplug notifier to do per-node sysfs creation and
> removal instead of inserting those operations to node registration and
> unregistration.  Then, it can reduce the code coupling between node.c and
> hugetlb.c.  Also, it can simplify the code.
>
> Signed-off-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>
> Acked-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
> Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
> Cc: David Hildenbrand <david@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Muchun Song <songmuchun@xxxxxxxxxxxxx>
> Cc: Oscar Salvador <osalvador@xxxxxxx>
> Cc: Rafael J. Wysocki <rafael@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---

Acked-by: David Hildenbrand <david@xxxxxxxxxx>

--
Thanks,

David / dhildenb