Re: [PATCH -next] power: supply: bq25890: Fix enum conversion in bq25890_power_supply_set_property()

[Sebastian Reichel]

Hi,

On Mon, Sep 12, 2022 at 08:11:59PM +0200, Marek Vasut wrote:
> On 9/12/22 16:15, Nathan Chancellor wrote:
> > Clang warns:
> > 
> >    drivers/power/supply/bq25890_charger.c:625:40: error: implicit conversion from enumeration type 'enum bq25890_fields' to different enumeration type 'enum bq25890_table_ids' [-Werror,-Wenum-conversion]
> >                    lval = bq25890_find_idx(val->intval, F_IINLIM);
> >                           ~~~~~~~~~~~~~~~~              ^~~~~~~~
> >    1 error generated.
> > 
> > Use the proper value from the right enumerated type, TBL_IINLIM, so
> > there is no more implcit conversion. The numerical values of F_IINLIM
> > and TBL_IINLIM happen to be the same so there is no change in behavior.
> > 
> > Fixes: 4a4748f28b0b ("power: supply: bq25890: Add support for setting IINLIM")
> > Link: https://github.com/ClangBuiltLinux/linux/issues/1707
> > Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> 
> Reviewed-by: Marek Vasut <marex@xxxxxxx>

Thanks, queued.

-- Sebastian

Attachment: signature.asc
Description: PGP signature