Re: [PATCH v13 1/3] x86/tdx: Add TDX Guest attestation interface driver

[Dave Hansen]

On 9/9/22 12:27, Kuppuswamy Sathyanarayanan wrote:
> 
>  arch/x86/coco/tdx/tdx.c         | 115 ++++++++++++++++++++++++++++++++
>  arch/x86/include/uapi/asm/tdx.h |  56 ++++++++++++++++
>  2 files changed, 171 insertions(+)
>  create mode 100644 arch/x86/include/uapi/asm/tdx.h

The SEV equivalent of this in in:

	drivers/virt/coco/sev-guest/sev-guest.c

right?

Why did you choose a different location?  Also, can you please study the
SEV implementation a bit?  It might help you find problems like the
ioctl() return code issue.  The SEV driver appears to have gotten that
right.