Re: [PATCH v9,5/7] arm64: dts: mt8195: Add efuse node to mt8195

[AngeloGioacchino Del Regno]

Il 17/08/22 10:07, bchihi@xxxxxxxxxxxx ha scritto:
> From: Alexandre Bailon <abailon@xxxxxxxxxxxx>
>
> Add efuse node.
> This will be required by the thermal driver to get the calibration data.
>
> Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx>
> Co-developed-by: Balsam CHIHI <bchihi@xxxxxxxxxxxx>
> Signed-off-by: Balsam CHIHI <bchihi@xxxxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/mediatek/mt8195.dtsi | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index 066c14989708..95967a0196d8 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -733,6 +733,18 @@ u2_intr_p3: usb2-intr-p3@189,2 {
>   				reg = <0x189 0x2>;
>   				bits = <7 5>;
>   			};
> +
> +			lvts_efuse_data1: lvts1-calib@1bc {
> +				reg = <0x1bc 0x14>;
> +			};
> +
> +			lvts_efuse_data2: lvts2-calib@1d0 {
> +				reg = <0x1d0 0x38>;
> +			};
> +
> +			svs_calibration: calib@580 {

The SVS calibration efuse is for the SVS driver, not for the LVTS.
Moreover, you're not using it later when you add the LVTS nodes, so, please
drop this one.

Regards,
Angelo