Re: [PATCH v4 1/2] dt-bindings: spmi: Add qcom,bus-id

From: Bjorn Andersson
Date: Wed Sep 14 2022 - 10:11:30 EST


On Wed, Sep 14, 2022 at 04:51:38PM +0530, Vinod Koul wrote:
> For PMIC arbiter version 7 and beyond we need to define if we are using
> primary or secondary bus, so add a new property of qcom,bus-id
>
> Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> .../devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> index fee4f0eb4665..aa8e891b2bb4 100644
> --- a/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> +++ b/Documentation/devicetree/bindings/spmi/qcom,spmi-pmic-arb.yaml
> @@ -85,6 +85,14 @@ properties:
> description: >
> which of the PMIC Arb provided channels to use for accesses
>
> + qcom,bus-id:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + minimum: 0
> + maximum: 1
> + description: >
> + SPMI bus instance. only applicable to PMIC arbiter version 7 and beyond.
> + Supported values, 0 = primary bus, 1 = secondary bus
> +
> required:
> - compatible
> - reg-names
> @@ -113,5 +121,8 @@ examples:
>
> interrupt-controller;
> #interrupt-cells = <4>;
> +
> + qcom,bus-id = <0>;
> +

As you correct the author on patch 2/2, please drop this last empty
line.

Thanks,
Bjorn

> };
>
> --
> 2.37.3
>