Re: [PATCH 1/2] ata: clean up how architectures enable PATA_PLATFORM and PATA_OF_PLATFORM
From: Arnd Bergmann
Date: Wed Sep 14 2022 - 10:36:26 EST
On Wed, Sep 14, 2022, at 4:27 PM, Lukas Bulwahn wrote:
> There are two options for platform device PATA support:
> PATA_PLATFORM: Generic platform device PATA support
> PATA_OF_PLATFORM: OpenFirmware platform device PATA support
> If an architecture allows the generic platform device PATA support, it
> shall select HAVE_PATA_PLATFORM. Then, Generic platform device PATA support
> is available and can be selected.
> If an architecture has OpenFirmware support, which it indicates by
> selecting OF, OpenFirmware platform device PATA support is available
> and can be selected.
> If OpenFirmware platform device PATA support is selected, then the
> functionality (code files) from Generic platform device PATA support needs
> to be integrated in the kernel build for the OpenFirmware platform device
> PATA support to work. Select PATA_PLATFORM in PATA_OF_PLATFORM to make sure
> the needed files are added in the build.
> So, architectures with OpenFirmware support, do not need to additionally
> select HAVE_PATA_PLATFORM. It is only needed by architecture that want the
> non-OF pata-platform module.
> Reflect this way of intended use of config symbols in the ata Kconfig and
> adjust all architecture definitions.
> This follows the suggestion from Arnd Bergmann (see Link).
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx>
Thanks for the follow-up, looks good.
Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>