Re: [PATCH v2 2/2] mm/page_io: count submission time as thrashing delay for delayacct
From: Joonsoo Kim
Date: Wed Sep 14 2022 - 10:49:56 EST
2022년 8월 15일 (월) 오후 4:33, <cgel.zte@xxxxxxxxx>님이 작성:
>
> From: Yang Yang <yang.yang29@xxxxxxxxxx>
>
> Once upon a time, we only support accounting thrashing of page cache.
> Then Joonsoo introduced workingset detection for anonymous pages and
> we gained the ability to account thrashing of them[1].
>
> Likes PSI, we count submission time as thrashing delay because when
> the device is congested, or the submitting cgroup IO-throttled,
> submission can be a significant part of overall IO time.
It's not the main purpose of this patch. Without this patch,
swap thrashing through frontswap or some block device supporting rw_page
operation isn't measured correctly. I think that description change is
required. Please refer to commit 937790699be9c8100e
(mm/page_io.c: annotate refault stalls from swap_readpage).
No objection on the code side.
Thanks.