Re: [PATCHv2 1/1] media: imx: Round line size to 4 bytes

[Dorota Czaplejewicz]

On Wed, 14 Sep 2022 18:45:05 +0300
Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:

> On Wed, Sep 14, 2022 at 05:32:36PM +0200, Dorota Czaplejewicz wrote:
> > Section 13.7.6.13 "CSI Image Parameter Register" of the
> > i.MX 8M Quad Applications Processors Reference Manual
> > states that the line size should be divisible by 8 bytes.
> > However, the hardware also accepts sizes divisible by 4 bytes,
> > which are needed to fully utilize the S5K3L6XX sensors.
> > 
> > This patch accepts line sizes divisible 4-bytes in non-planar mode.
> > 
> > ---  
> 
> So do we need a Fixes tag?  Was this ever working in kernel?
> 
No, it wasn't actually ever working upstream, just in a patched up branch I mixed up with the real thing.
> Definitely need a Signed-off-by line, though. ;)

Thanks again!
--Dorota
> 
> regards,
> dan carpenter
>

Attachment: pgpVv8ByDwLXi.pgp
Description: OpenPGP digital signature