Re: [PATCH v13 1/3] x86/tdx: Add TDX Guest attestation interface driver

From: Sathyanarayanan Kuppuswamy
Date: Wed Sep 14 2022 - 12:27:48 EST




On 9/14/22 9:12 AM, Dave Hansen wrote:
> On 9/14/22 08:36, Sathyanarayanan Kuppuswamy wrote:
>> When we initially submitted the attestation patches, virt/coco folder
>> was not created. I initially kept this driver in platform/x86/, but
>> later moved to arch/x86/coco based on the review comments in v4. There
>> was a discussion about the need for a new config and the location of
>> the driver. The outcome of that discussion is, since this is not a
>> traditional driver, but a basic TDX feature, we don't need a special
>> config and the code can be maintained in the arch/x86/coco folder.
>
> Could you please include the following in this set somewhere:
>
> "The code to do the SEV analog of this TDX functionality is in
> ___insert_path_here____. This code is different from that because
> ______reason______ so it is instead placed in ____other_path____."
>
> ?

Ok. I will include it in the cover letter.

--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer