Re: [PATCH v13 05/13] nvme: zns: Allow ZNS drives that have non-power_of_2 zone size

[Chaitanya Kulkarni]

On 9/12/2022 1:21 AM, Pankaj Raghav wrote:
> Remove the condition which disallows non-power_of_2 zone size ZNS drive
> to be updated and use generic method to calculate number of zones
> instead of relying on log and shift based calculation on zone size.
> 
> The power_of_2 calculation has been replaced directly with generic
> calculation without special handling. Both modified functions are not
> used in hot paths, they are only used during initialization &
> revalidation of the ZNS device.
> 
> As rounddown macro from math.h does not work for 32 bit architectures,
> round down operation is open coded.
> 
> Reviewed-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> Reviewed by: Adam Manzanares <a.manzanares@xxxxxxxxxxx>
> Reviewed-by: Hannes Reinecke <hare@xxxxxxx>
> Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>
> Signed-off-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx>
>


Reviewed-by: Chaitanya Kulkarni <kch@xxxxxxxxxx>

-ck