Re: [PATCH 04/16] mm/page_alloc: remove obsolete comment in zone_statistics()

From: Oscar Salvador
Date: Thu Sep 15 2022 - 00:47:48 EST


On Fri, Sep 09, 2022 at 05:24:39PM +0800, Miaohe Lin wrote:
> Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs
> are disabled for VM counters"), zone_statistics() is not called with
> interrupts disabled. Update the corresponding comment.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>

Reviewed-by: Oscar Salvador <osalvador@xxxxxxx>

> ---
> mm/page_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 2deac2fe3372..c81f06d8a4f5 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt)
>
> /*
> * Update NUMA hit/miss statistics
> - *
> - * Must be called with interrupts disabled.
> */
> static inline void zone_statistics(struct zone *preferred_zone, struct zone *z,
> long nr_account)
> --
> 2.23.0
>

--
Oscar Salvador
SUSE Labs