Re: [PATCH v1 2/2] Revert "drm/bridge: ti-sn65dsi86: Implement bridge connector operations for DP"

[Robert Foss]

On Mon, 12 Sept 2022 at 16:43, Laurent Pinchart
<laurent.pinchart@xxxxxxxxxxxxxxxx> wrote:
>
> On Mon, Sep 12, 2022 at 03:29:52PM +0100, Doug Anderson wrote:
> > On Mon, Sep 12, 2022 at 12:43 PM Robert Foss <robert.foss@xxxxxxxxxx> wrote:
> > >
> > > As reported by Laurent in response to this commit[1], this functionality should
> > > not be implemented using the devicetree, because of this let's revert this series
> > > for now.
> > >
> > > This reverts commit c312b0df3b13e4c533743bb2c37fd1bc237368e5.
> > >
> > > [1] https://lore.kernel.org/all/20220902153906.31000-2-macroalpha82@xxxxxxxxx/
> > >
> > > Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
> > > ---
> > >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 28 ---------------------------
> > >  1 file changed, 28 deletions(-)
> >
> > Any chance you got confused and reverted the wrong patch? This
> > ti-sn65dsi86 patch doesn't seem relevant to the problems talked about
> > in the commit or the cover letter. Maybe I'm missing something?
>
> Aarghhh I missed that when checking the cover letter :-( This indeed
> seems wrong.

Yep. This is a mistake. I copy/pasted the wrong line and then assumed
that ti-sn65dsi86 & chrontel-ch7033 shared a driver. I'll look into my
workflows to try to prevent future mistakes of this nature.

A series fixing this has been posted.
https://lore.kernel.org/all/20220915102924.370090-1-robert.foss@xxxxxxxxxx/

Thanks for catching this Doug!


Rob.