Re: [PATCH 1/3] drm/mediatek: dp: Refactor drivers in mtk_dp_bdg_detect()

From: AngeloGioacchino Del Regno
Date: Thu Sep 15 2022 - 06:34:20 EST

Next message: Greg Kroah-Hartman: "Linux 4.19.258"
Previous message: kernel test robot: "[asahilinux:bits/080-wifi 20/29] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1087:28: sparse: sparse: incorrect type in assignment (different base types)"
In reply to: Bo-Chen Chen: "[PATCH 1/3] drm/mediatek: dp: Refactor drivers in mtk_dp_bdg_detect()"
Next in thread: Bo-Chen Chen: "[PATCH 3/3] drm/mediatek: dp: Fix warning in mtk_dp_video_mute()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Il 15/09/22 09:50, Bo-Chen Chen ha scritto:

It is more clear to modify this in mtk_dp_bdg_detect().

I agree with this commit. Since you anyway have to send a v2 of this series,
please clarify the commit description and title, something like:

drm/mediatek: dp: Reduce indentation in mtk_dp_bdg_detect()

In order to improve human readability, reduce the indentation by returning
early if the dp/edp cable is not plugged in.

Cheers,
Angelo

Next message: Greg Kroah-Hartman: "Linux 4.19.258"
Previous message: kernel test robot: "[asahilinux:bits/080-wifi 20/29] drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c:1087:28: sparse: sparse: incorrect type in assignment (different base types)"
In reply to: Bo-Chen Chen: "[PATCH 1/3] drm/mediatek: dp: Refactor drivers in mtk_dp_bdg_detect()"
Next in thread: Bo-Chen Chen: "[PATCH 3/3] drm/mediatek: dp: Fix warning in mtk_dp_video_mute()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]