Re: [PATCH V9 1/7] dt-bindings: Added the yaml bindings for DCC

[Souradeep Chowdhury]

On 9/15/2022 9:05 AM, Bjorn Andersson wrote:
> On Wed, Sep 14, 2022 at 10:31:11PM +0530, Souradeep Chowdhury wrote:
> > Documentation for Data Capture and Compare(DCC) device tree bindings
> > in yaml format.
> >
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > Signed-off-by: Souradeep Chowdhury <quic_schowdhu@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/arm/msm/qcom,dcc.yaml      | 43 ++++++++++++++++++++++
> >   1 file changed, 43 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
> > new file mode 100644
> > index 0000000..b7a6619
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
> > @@ -0,0 +1,43 @@
> > +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Data Capture and Compare
> > +
> > +maintainers:
> > +  - Souradeep Chowdhury <schowdhu@xxxxxxxxxxxxxx>
> Please update your email address.
Ack
> > +
> > +description: |
> > +    DCC (Data Capture and Compare) is a DMA engine which is used to save
> > +    configuration data or system memory contents during catastrophic failure
> > +    or SW trigger. DCC is used to capture and store data for debugging purpose
> An empty line inbetween description and properties would be nice.
Ack
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - qcom,sm8150-dcc
> > +          - qcom,sc7280-dcc
> > +          - qcom,sc7180-dcc
> > +          - qcom,sdm845-dcc
> > +      - const: qcom,dcc
> > +
> > +  reg:
> > +    items:
> > +      - description: DCC base register region
> > +      - description: DCC RAM base register region
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    dma@10a2000{
> > +                compatible = "qcom,sm8150-dcc","qcom,dcc";
> > +                reg = <0x010a2000  0x1000>,
> > +                      <0x010ad000  0x2000>;
> Please remove the double space between address and size.
Ack
> Regards,
> Bjorn
>
>
> > +    };
> > --
> > 2.7.4