Re: [RESEND PATCH] ixgbe: Don't call kmap() on page allocated with GFP_ATOMIC

[Ira Weiny]

On Thu, Sep 15, 2022 at 09:30:50AM -0700, Tony Nguyen wrote:
> 
> 
> On 9/15/2022 5:40 AM, Fabio M. De Francesco wrote:
> > Pages allocated with GFP_ATOMIC cannot come from Highmem. This is why
> > there is no need to call kmap() on them.
> > 
> > Therefore, don't call kmap() on rx_buffer->page() and instead use a
> > plain page_address() to get the kernel address.
> > 
> > Suggested-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> > Suggested-by: Alexander Duyck <alexander.duyck@xxxxxxxxx>
> > Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>
> > Reviewed-by: Alexander Duyck <alexander.duyck@xxxxxxxxx>
> > Tested-by: Gurucharan <gurucharanx.g@xxxxxxxxx>
> > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
> > ---
> > 
> > I send again this patch because it was submitted more than two months ago,
> > Monday 4th July 2022, but for one or more (good?) reasons it has not yet
> > reached Linus' tree. In the meantime I am also forwarding two "Reviewed-by"
> > and one "Tested-by" tags (thanks a lot to Ira, Alexander, Gurucharan).
> > Obviously I have not made any changes to the code.
> 
> Hi Fabio,
> 
> This is accepted into net-next already[1] and will land in the next kernel.

Thanks, sorry just saw this after sending my last.  :-/  :-D

Ira

> 
> Thanks,
> Tony
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=03f51719df032637250af828f9a1ffcc5695982d