Re: [PATCH] fat: device-level-flush-after-sync

From: kernel test robot
Date: Thu Sep 15 2022 - 16:22:25 EST

Hi Gianfranco,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.0-rc5 next-20220915]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in]

base: 3245cb65fd91cd514801bf91f5a3066d562f0ac4
config: x86_64-randconfig-a012 (
compiler: clang version 14.0.6 ( f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add linux-review
git fetch --no-tags linux-review Gianfranco/fat-device-level-flush-after-sync/20220915-014337
git checkout b1130c74311f7b8c0713f373a8dc20b572883fca
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> fs/fat/inode.c:829:41: error: too many arguments to function call, expected single argument 'bdev', have 3 arguments
return blkdev_issue_flush(sb->s_bdev, GFP_KERNEL, NULL);
~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~
include/linux/gfp_types.h:333:20: note: expanded from macro 'GFP_KERNEL'
include/linux/blkdev.h:1031:5: note: 'blkdev_issue_flush' declared here
int blkdev_issue_flush(struct block_device *bdev);
1 error generated.

vim +/bdev +829 fs/fat/inode.c

826 static int fat_sync_fs(struct super_block *sb, int wait)
827 {
828 if (wait)
> 829 return blkdev_issue_flush(sb->s_bdev, GFP_KERNEL, NULL);
830 else
831 return 0;
832 }

0-DAY CI Kernel Test Service