Re: [PATCH V4 3/6] erofs: introduce fscache-based domain

[JeffleXu]

On 9/15/22 8:42 PM, Jia Zhu wrote:
>  
> +static void erofs_fscache_domain_put(struct erofs_domain *domain)
> +{
> +	if (!domain)
> +		return;
> +	mutex_lock(&erofs_domain_list_lock);
> +	if (refcount_dec_and_test(&domain->ref)) {
> +		list_del(&domain->list);
> +		fscache_relinquish_volume(domain->volume, NULL, false);
> +		mutex_unlock(&erofs_domain_list_lock);

I think we can mutex_unlock as long as the domain is removed from the list.


Otherwise LGTM.
Reviewed-by: Jingbo Xu <jefflexu@xxxxxxxxxxxxxxxxx>

-- 
Thanks,
Jingbo