Re: [PATCH v2 1/2] random: move add_hwgenerator_randomness()'s wait outside function

From: Dominik Brodowski
Date: Fri Sep 16 2022 - 02:24:15 EST


Am Thu, Sep 15, 2022 at 02:54:24PM -0400 schrieb Sven van Ashbrook:
> Dominik, Jason,
>
> On Thu, Sep 15, 2022 at 11:44 AM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote:
> >
> > Isn't Dominik working on the same thing, but slightly different?
>
> I don't believe Dominik is working on quite the same thing, but his
> work will conflict with mine for sure:
> https://lore.kernel.org/lkml/YxiXEJ6up6XEW8SM@xxxxxxxxx/T/
>
> What are the odds that two people are making changes to the hwrng
> kthread at the same time?
>
> I see two possible ways forward:
> 1. Dominik rebases his patch against mine (iff mine finds favour).
> This may simplify his patch
> quite a bit, because the delayed_work abstraction tends to have fewer
> footguns than
> kthread.
>
> or
>
> 2. I rebase against Dominik's.
>
> Both are fine with me, just let me know what you think.

Indeed, our patches address different issues. I'm fine with both approaches,
i.e. my patches to be based on Sven's, or the other way round.

Best,
Dominik