Re: [PATCH v5 4/5] iommu/io-pgtable-dart: Add DART PTE support for t6000

[Rob Herring]

On Fri, Sep 16, 2022 at 4:42 AM Janne Grunau <j@xxxxxxxxxx> wrote:
>
> From: Sven Peter <sven@xxxxxxxxxxxxx>
>
> The DARTs present in the M1 Pro/Max/Ultra SoC use a diffent PTE format.
> They support a 42bit physical address space by shifting the paddr and
> extending its mask inside the PTE.
> They also come with mandatory sub-page protection now which we just
> configure to always allow access to the entire page. This feature is
> already present but optional on the previous DARTs which allows to
> unconditionally configure it.
>
> Signed-off-by: Sven Peter <sven@xxxxxxxxxxxxx>
> Co-developed-by: Janne Grunau <j@xxxxxxxxxx>
> Signed-off-by: Janne Grunau <j@xxxxxxxxxx>
>
> ---
>
> (no changes since v3)
>
> Changes in v3:
> - apply change to io-pgtable-dart.c
> - handle pte <> paddr conversion based on the pte format instead of
>   the output address size
>
> Changes in v2:
> - add APPLE_DART2 PTE format
>
>  drivers/iommu/io-pgtable-dart.c | 49 ++++++++++++++++++++++++++++-----
>  drivers/iommu/io-pgtable.c      |  1 +
>  include/linux/io-pgtable.h      |  1 +
>  3 files changed, 44 insertions(+), 7 deletions(-)

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>