Re: Re: [PATCH 1/2] dt-bindings: firmware: imx: sync with SCFW kit v1.13.0

From: Alexander Stein
Date: Fri Sep 16 2022 - 09:04:01 EST


Hi Viorel,

added missing CC.

Am Freitag, 16. September 2022, 13:09:36 CEST schrieb Viorel Suman:
> On 22-09-16 08:30:46, Alexander Stein wrote:
> > Am Donnerstag, 15. September 2022, 20:18:04 CEST schrieb Viorel Suman
(OSS):
> > > From: Viorel Suman <viorel.suman@xxxxxxx>
> > >
> > > Sync defines with the latest available SCFW kit version 1.13.0,
> > > may be found at the address below:
> > >
> > > https://www.nxp.com/webapp/Download?colCode=L5.15.32_2.0.0_SCFWKIT-1.13.
> > > 0&ap pType=license
> > >
> > > Signed-off-by: Viorel Suman <viorel.suman@xxxxxxx>
> > > ---
> > >
> > > include/dt-bindings/firmware/imx/rsrc.h | 299 ++++++++++++++++--------
> > > 1 file changed, 203 insertions(+), 96 deletions(-)
> >
> > This is not bisectable and breaks compilation, as this patch removes
> > symbols which are still used in drivers/clk/imx/clk-imx8qm-rsrc.c
> > (addressed in 2nd patch). IMHO this series should be squashed into one
> > patch.
>
> Hi Alexander,
>
> Thank you for review, you are right. Is sending a squashed v2 the usual
> approach in such case or shall I hope that the maintainer will squash them
> before push ? Just want to avoid unnecessary noise.

AFAIK maintainers will not squash patches. This is something you will need to
do yourself. So sending a v2 seems right.
Also please keep all the other recipients on CC.

Best regards,
Alexander