Re: [RFC PATCH 06/23] sched/core: Update the classification of the current task

From: Ricardo Neri
Date: Fri Sep 16 2022 - 10:37:06 EST


On Wed, Sep 14, 2022 at 03:44:29PM +0200, Peter Zijlstra wrote:
> On Fri, Sep 09, 2022 at 04:11:48PM -0700, Ricardo Neri wrote:
>
> > + if (sched_task_classes_enabled() && user_tick)
> > + arch_update_task_class(curr, is_core_idle(cpu));
>
> This evaluates is_core_idle() even if the hardware improves.

Yes, this is true. Do you think it would make sense to expose is_core_idle()
outside the scheduler? In this manner, only hardware that needs it would
call it.

Thanks and BR,
Ricardo
>