Re: [PATCH 3/4] slimbus: qcom-ngd-ctrl: Make QMI message rules const

From: Jeff Johnson
Date: Fri Sep 16 2022 - 11:21:13 EST


On 9/16/2022 6:06 AM, Srinivas Kandagatla wrote:


On 13/09/2022 00:25, Jeff Johnson wrote:
Commit ff6d365898d ("soc: qcom: qmi: use con

SHA ID should be at least 12 chars long.

Same comment for all the patches in the series.


st for struct
qmi_elem_info") allows QMI message encoding/decoding rules to be
const, so do that for qcom-ngd-ctrl.

Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>

Other than that it LGTM,
Once fixed:

Acked-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>


--srini

that was corrected in v2. thx for the ack