Re: [PATCH v4 01/13] x86/resctrl: Fix min_cbm_bits for AMD

From: Reinette Chatre
Date: Fri Sep 16 2022 - 11:52:55 EST


Hi Babu,

On 9/12/2022 7:54 AM, Moger, Babu wrote:
> On 9/9/22 12:00, James Morse wrote:
>> On 07/09/2022 18:59, Babu Moger wrote:


>>> Fixes: 316e7f901f5a ("x86/resctrl: Add struct rdt_cache::arch_has_{sparse, empty}_bitmaps")
>>> Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>
>>> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
>> Er, who is the author if this patch? If you are reposting Stephane's patch then there
>> needs to be a 'From: ' at the top of the email so that git preserves the ownership. You
>
> I can add Stephane's name in "From" if it is right thing to do. But this
> patch was modified from the original version Stephane posted.
>
> https://lore.kernel.org/lkml/20220517001234.3137157-1-eranian@xxxxxxxxxx/

True, but also please consider what Stephane posted originally:
https://lore.kernel.org/lkml/20220516055055.2734840-1-eranian@xxxxxxxxxx/

A "Co-developed-by" may help with attribution:

Co-developed-by: Stephane Eranian <eranian@xxxxxxxxxx>
Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>
Signed-off-by: Babu Moger <babu.moger@xxxxxxx>

Reinette