Re: [PATCH] iommu: Optimise PCI SAC address trick
From: kernel test robot
Date: Fri Sep 16 2022 - 23:06:13 EST
Hi Robin,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.0-rc5 next-20220916]
[cannot apply to joro-iommu/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Robin-Murphy/iommu-Optimise-PCI-SAC-address-trick/20220917-025450
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 6879c2d3b96039ff1668b4328a4d0dd3ea952cff
config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220917/202209171032.XILNq94O-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/1ca86b189e7b2485d270f516a4547306fa8dc941
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Robin-Murphy/iommu-Optimise-PCI-SAC-address-trick/20220917-025450
git checkout 1ca86b189e7b2485d270f516a4547306fa8dc941
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/iommu/iommu.c: In function '__iommu_probe_device':
>> drivers/iommu/iommu.c:259:14: error: 'iommu_dma_forcedac' undeclared (first use in this function)
259 | if (!iommu_dma_forcedac && dev_is_pci(dev))
| ^~~~~~~~~~~~~~~~~~
drivers/iommu/iommu.c:259:14: note: each undeclared identifier is reported only once for each function it appears in
vim +/iommu_dma_forcedac +259 drivers/iommu/iommu.c
220
221 static int __iommu_probe_device(struct device *dev, struct list_head *group_list)
222 {
223 const struct iommu_ops *ops = dev->bus->iommu_ops;
224 struct iommu_device *iommu_dev;
225 struct iommu_group *group;
226 int ret;
227
228 if (!ops)
229 return -ENODEV;
230
231 if (!dev_iommu_get(dev))
232 return -ENOMEM;
233
234 if (!try_module_get(ops->owner)) {
235 ret = -EINVAL;
236 goto err_free;
237 }
238
239 iommu_dev = ops->probe_device(dev);
240 if (IS_ERR(iommu_dev)) {
241 ret = PTR_ERR(iommu_dev);
242 goto out_module_put;
243 }
244
245 dev->iommu->iommu_dev = iommu_dev;
246
247 group = iommu_group_get_for_dev(dev);
248 if (IS_ERR(group)) {
249 ret = PTR_ERR(group);
250 goto out_release;
251 }
252 iommu_group_put(group);
253
254 if (group_list && !group->default_domain && list_empty(&group->entry))
255 list_add_tail(&group->entry, group_list);
256
257 iommu_device_link(iommu_dev, dev);
258
> 259 if (!iommu_dma_forcedac && dev_is_pci(dev))
260 dev->iommu->pci_workaround = true;
261
262 return 0;
263
264 out_release:
265 if (ops->release_device)
266 ops->release_device(dev);
267
268 out_module_put:
269 module_put(ops->owner);
270
271 err_free:
272 dev_iommu_free(dev);
273
274 return ret;
275 }
276
--
0-DAY CI Kernel Test Service
https://01.org/lkp