Re: [RFC PATCH] nvme: request remote is usually not involved for nvme devices

From: Jens Axboe
Date: Sat Sep 17 2022 - 12:50:35 EST


On 9/17/22 10:40 AM, Liu Song wrote:
> From: Liu Song <liusong@xxxxxxxxxxxxxxxxx>
>
> NVMe devices usually have a 1:1 mapping between "ctx" and "hctx",
> so when "nr_ctx" is equal to 1, there is no possibility of remote
> request, so the corresponding process can be simplified.

If the worry is the call overhead of blk_mq_complete_request_remote(),
why don't we just make that available as an inline instead? That seems
vastly superior to providing a random shortcut in a driver to avoid
calling it.

--
Jens Axboe