Re: [linux][PATCH v9 2/2] dts: arm: at91: Add SAMA5D3-EDS Board

[Krzysztof Kozlowski]

On 13/09/2022 15:53, Jerry.Ray@xxxxxxxxxxxxx wrote:
>>> The SAMA5D3-EDS board is an Ethernet Development Platform allowing for 
>>> evaluating many Microchip ethernet switch and PHY products.  Various 
>>> daughter cards can connect via an RGMII connector or an RMII connector.
>>>
>>> The EDS board is not intended for stand-alone use and has no ethernet 
>>> capabilities when no daughter board is connected.  As such, this 
>>> device tree is intended to be used with a DT overlay defining the add-on board.
>>> To better ensure consistency, some items are defined here as a form of 
>>> documentation so that all add-on overlays will use the same terms.
>>>
>>> Link: 
>>> https://www.microchip.com/en-us/development-tool/SAMA5D3-ETHERNET-DEVE
>>> LOPMENT-SYSTEM
>>> Signed-off-by: Jerry Ray <jerry.ray@xxxxxxxxxxxxx>
>>> ---
>>> v8->v9:
>>>  - Changed node name from gpio to gpio-inputs
>>
>> Why not gpio-keys as all other DTSes are doing? Anyway, I can change it while applying.
>>
>> Thank you,
>> Claudiu Beznea
>>
> 
> gpio-keys is the compatible string name. I wanted the node name to be unique
> for grep purposes.

Node names should not be unique but generic.

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> 
> Regards,
> Jerry.
> 
>>> v7->v8:
>>>  - correcting patch subject line.
>>> v6->v7:

Please trim your replies... there is no need to quote everything after
the comment.

(snip)


Best regards,
Krzysztof