Re: [PATCH] i2c: hix5hd2: Add some debug enhancement for register access

[Wolfram Sang]

On Tue, Sep 13, 2022 at 12:48:20PM +0000, Tao Lan wrote:
> From: taolan <taolan@xxxxxxxxxx>
> 
> Sometimes, to locate a fault, we need to know how the register is
> configured and whether the configuration is incorrect. Currently, no
> better method is available for analysis.
> 
> This patch tries to solve the problem by naming the registers and
> printing the accessed values.
> 
> Signed-off-by: taolan <taolan@xxxxxxxxxx>

Such debug helpers are not suitable for upstream because they need quite
some resources for rare cases...

> +		pr_notice("write 0x%04x to %s\n", val, g_i2c_reg_name[idx >> 0x2].name);

... and using this loglevel you will flood logs of users.

Attachment: signature.asc
Description: PGP signature