Re: [PATCH] phy: rockchip-inno-usb2: Fix otg port initialization

From: Mikhail Rudenko
Date: Sun Sep 18 2022 - 13:47:27 EST



On 2022-09-17 at 12:12 -05, Samuel Holland <samuel@xxxxxxxxxxxx> wrote:
> On 9/17/22 11:58, Mikhail Rudenko wrote:
>> There are two issues in rockchip_usb2phy_otg_port_init(): (1) even if
>> devm_extcon_register_notifier() returns error, the code proceeds to
>> the next if statement and (2) if no extcon is defined in of_node, the
>> return value of property_enabled() is reused as the return value of
>> the whole function. If the return value of property_enable() is
>> nonzero, (2) results in an unexpected probe failure and kernel panic
>> in delayed work:
>
> This should be fixed by the following patch which is accepted already:
>
> https://lore.kernel.org/lkml/20220902184543.1234835-1-pgwipeout@xxxxxxxxx/

Ah, I see now. Sorry for the noise!

--
Best regards,
Mikhail Rudenko