Re: [PATCH 16/21] dt-bindings: reserved-memory: introduce designated-movable-block

From: Doug Berger
Date: Sun Sep 18 2022 - 18:41:51 EST


On 9/18/2022 3:28 AM, Krzysztof Kozlowski wrote:
On 13/09/2022 20:55, Doug Berger wrote:
Introduce designated-movable-block.yaml to document the
devicetree binding for Designated Movable Block children of the
reserved-memory node.

Signed-off-by: Doug Berger <opendmb@xxxxxxxxx>
---
.../designated-movable-block.yaml | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/reserved-memory/designated-movable-block.yaml

diff --git a/Documentation/devicetree/bindings/reserved-memory/designated-movable-block.yaml b/Documentation/devicetree/bindings/reserved-memory/designated-movable-block.yaml
new file mode 100644
index 000000000000..42f846069a2e
--- /dev/null
+++ b/Documentation/devicetree/bindings/reserved-memory/designated-movable-block.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/reserved-memory/designated-movable-block.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: /reserved-memory Designated Movable Block node binding

Drop "binding"

+
+maintainers:
+ - devicetree-spec@xxxxxxxxxxxxxxx
+
+allOf:
+ - $ref: "reserved-memory.yaml"

Skip quotes

+
+properties:
+ compatible:
+ const: designated-movable-block
+ description:
+ This indicates a region of memory meant to be placed into
+ ZONE_MOVABLE.
+
+unevaluatedProperties: false
+
+required:
+ - compatible
+ - reusable
+
+examples:
+ - |
+ reserved-memory {

Use 4 spaces for example indentation.

+ #address-cells = <0x2>;
+ #size-cells = <0x2>;
+
+ DMB0@10800000 {

The convention for node names is to use lowercase and generic node
names, so just "dmb".



Best regards,
Krzysztof
Thanks for taking the time to review and provide feedback on this patch.
-Doug