RE: Re: [PATCH v2 01/13] trinity: Add base driver

From: MyungJoo Ham
Date: Sun Sep 18 2022 - 22:57:22 EST


> On Sun, 18 Sep 2022 12:35:23 +0200
> Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > On Sat, Sep 17, 2022 at 04:23:44PM +0900, Jiho Chu wrote:
> > > It contains the base codes for trinity driver. Minimal codes to load and
> > > probe device is provided. The Trinity Family is controlled by the
> > > Memory-Mapped Registers, the register addresses and offsets are
> > > described. And user api interfaces are presented to control device under
> > > ioctl manner.
> >
> > Where is the documentation for how the userspace api works? And where
> > is a link to the userspace code that talks to these devices? That
> > belongs here in this commit changelog text please.
> >
>
> Hi, Greg
> Thanks for your review.
>
> The user space library is published in:
> https://review.tizen.org/gerrit/gitweb?p=platform/adaptation/npu/trix-engine.git;a=summary
>
> It needs to login to tizen, access guide is:
> https://docs.tizen.org/platform/get-started/open-source-project/
>
> And, this information will be included in commit log.

The URL without log-in is more appropriate.

Please use https://git.tizen.org/cgit/platform/adaptation/npu/trix-engine/
instead of review.tizen.org.

Cheers,
MyungJoo